Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds utility functions ios #140

Closed
wants to merge 6 commits into from
Closed

Adds utility functions ios #140

wants to merge 6 commits into from

Conversation

mundruid
Copy link
Contributor

@mundruid mundruid commented Aug 3, 2022

Adds:

  • get_path
  • get_path_with_children

Addresses partially issue: #124

Copy link
Collaborator

@qduk qduk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the docs fix!

netutils/config/parser.py Outdated Show resolved Hide resolved
netutils/config/parser.py Outdated Show resolved Hide resolved
netutils/config/parser.py Outdated Show resolved Hide resolved
netutils/config/parser.py Outdated Show resolved Hide resolved
netutils/config/parser.py Outdated Show resolved Hide resolved
@itdependsnetworks
Copy link
Contributor

I don't understand how there is actually tests here? There just seems to be configurations, but nothing saying that configuration 1 should be parsed as X.

@mundruid
Copy link
Contributor Author

I don't understand how there is actually tests here? There just seems to be configurations, but nothing saying that configuration 1 should be parsed as X.

Are you referring to the unit tests that I wrote? I parse an ios configuration and use the functions that are written: find_all_children and find_children_w_parents. These two functions are the units under test. Then I compare the output of these functions with the expected output. If the test passes, I consider the unit, i.e. the functions mentioned, tested. I also consider that this is the expected behavior. Are you expecting something different for the unit tests?

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants