Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add whereNotHashedIds scope #5

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Conversation

bensherred
Copy link
Collaborator

Overview

  • I have performed a self review of my code
  • I have made corresponding changes to the documentation
  • I have commented my code, particularly in hard-to-understand areas
  • I have added sufficient logging
  • New and existing tests pass locally with my changes
  • The code modified as part of this PR has been covered with tests

Problem statement

This package has a scope called whereHashedIds which allows us to get all models where the ids match the hashed ids. However, there are times where we need to get all records where the hashed id is not in the array.

Solution

This PR adds a new whereNotHashedIds scope.

@bensherred bensherred merged commit 945b659 into main Jan 17, 2024
6 checks passed
@bensherred bensherred deleted the feature/where-not-hashed-ids branch January 17, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants