Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pan: PingingSelector apparently broken, masked by fallback behavior #250

Open
benthor opened this issue Mar 22, 2024 · 0 comments
Open

pan: PingingSelector apparently broken, masked by fallback behavior #250

benthor opened this issue Mar 22, 2024 · 0 comments

Comments

@benthor
Copy link
Contributor

benthor commented Mar 22, 2024

The PingingSelector in pan has probably been broken for a while. This hasn't been noticed, because, in the absence of meaningful measurements, it reverts to returning the first (i.e., shortest) path it knows.

I hit upon this problem by adding some code to inspect the state of pathStatsDB while the PingingSelector is in use. It's internal maps remain unpopulated no matter how long the PingingSelector is in use. I also tested this with the scion-ssh-client implementation to confirm the problem.

The PingingSelector uses somewhat low-level code to obtain the latency measurements in the backend. Perhaps something changed on the wire since then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant