The installer scripts fails on fedora - config-manager broken arguments

[ricardo-st]

Describe the problem
The install script does not finalize in fedora.

It returns:
Unknown argument "--add-repo" for command "config-manager". Add "--help" for more information about the arguments.

The fix is easy, change:

        ${SUDO} dnf config-manager --add-repo /etc/yum.repos.d/netbird.repo

for

        ${SUDO} dnf config-manager addrepo --from-repofile=/etc/yum.repos.d/netbird.repo

To Reproduce

Steps to reproduce the behavior:
Run curl -fsSL https://pkgs.netbird.io/install.sh | sh in a clean fedora install.

Expected behavior

The script installs.

Are you using NetBird Cloud?

Self-Hosted

NetBird version

0.34.1

NetBird status -dA output:

N/A

Do you face any (non-mobile) client issues?

N/A

Screenshots

N/A

Additional context

N/A

[mohamed-essam]

I have a fresh Fedora 40 installation and the script worked normally, and in my dnf config-manager --help it shows:

Config-manager command-specific options:
  --save                save the current options (useful with --setopt)
  --add-repo URL        add (and enable) the repo from the specified file or
                        url

According to this page this is a new format for Fedora 41+, so the script will need to detect which version it is to change the command accordingly to maintain backward compatibility.

[mohamed-essam]

@ricardo-st Could you test this install script to ensure it works on DNF v5+ (I tested on dnf v4 and it works correctly) 🙏
#3026

[orchard0]

@mohamed-essam Salam. Your commit fixes the issue with the dnf v5 argument changes. Another issue is that OpenPGP checks for packages from the repo are being skipped. Is there a key issue?

[mohamed-essam]

@orchard0 im not sure, does that only happen with dnf v5?

[orchard0]

Thank God I notice that gpgcheck=0 on line 124 in the install script. If I manually change that to gpgcheck=1 then I get the following error:

OpenPGP check for package "netbird-ui-0.34.1-1.x86_64" (/var/cache/libdnf5/NetBird-3f1333a6e9119c03/packages/netbird-ui_0.34.1_linux_amd64.rpm) from repo "NetBird" has failed: The package is not signed.

I get the same message for the main package:

OpenPGP check for package "netbird-0.34.1-1.x86_64" (/var/cache/libdnf5/NetBird-3f1333a6e9119c03/packages/netbird_0.34.1_linux_amd64.rpm) from repo "NetBird" has failed: The package is not signed.

Are the packages not signed?

[orchard0]

The key issue has been reported before earlier this year: #1698