Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update spawn syscalls #436

Merged
merged 15 commits into from
Oct 27, 2024
Merged

Update spawn syscalls #436

merged 15 commits into from
Oct 27, 2024

Conversation

mohanson
Copy link
Contributor

@mohanson mohanson commented Apr 19, 2024 •
edited
Loading

@mohanson mohanson requested a review from a team as a code owner April 19, 2024 06:05
@mohanson mohanson requested a review from jordanmack April 19, 2024 06:05
@mohanson mohanson mentioned this pull request Apr 19, 2024
Merged
xxuejie
xxuejie previously approved these changes Apr 25, 2024
View reviewed changes
rfcs/0050-vm-syscalls-3/0050-vm-syscalls-3.md Outdated Show resolved Hide resolved
rfcs/0050-vm-syscalls-3/0050-vm-syscalls-3.md Show resolved Hide resolved
rfcs/0050-vm-syscalls-3/0050-vm-syscalls-3.md Outdated Show resolved Hide resolved
rfcs/0050-vm-syscalls-3/0050-vm-syscalls-3.md Outdated Show resolved Hide resolved
rfcs/0050-vm-syscalls-3/0050-vm-syscalls-3.md Outdated Show resolved Hide resolved
@xxuejie xxuejie mentioned this pull request Apr 27, 2024
Open
xxuejie
xxuejie reviewed May 6, 2024
View reviewed changes
Copy link
Contributor

@xxuejie xxuejie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some hard limits to the system, such as:

  • How many VMs can be instantiated at the same time?
  • The maximum number of VMs(including suspended ones) a scheduler can spawn?

Are those documented anywhere?

rfcs/0050-vm-syscalls-3/0050-vm-syscalls-3.md Show resolved Hide resolved
@mohanson
Copy link
Contributor Author

mohanson commented May 6, 2024

There are some hard limits to the system, such as:

  • How many VMs can be instantiated at the same time?
  • The maximum number of VMs(including suspended ones) a scheduler can spawn?

Are those documented anywhere?

Descriptions have been added about the number of vm, the number of instantied vm and the number of pipes.

15168316096
15168316096 approved these changes May 31, 2024
View reviewed changes
Copy link

@15168316096 15168316096 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scenarios [0, 1, 1], [1, 0, 1], and [1, 1, 0] have already been verified.

rfcs/0050-vm-syscalls-3/0050-vm-syscalls-3.md Show resolved Hide resolved
@doitian doitian mentioned this pull request Aug 19, 2024
Closed
3 tasks
XuJiandong
XuJiandong previously approved these changes Sep 10, 2024
View reviewed changes
@XuJiandong XuJiandong requested a review from quake September 10, 2024 03:19
@zhangsoledad zhangsoledad merged commit 05843e1 into nervosnetwork:master Oct 27, 2024
1 check passed
@mohanson mohanson deleted the spawn_syscall branch October 28, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xxuejie xxuejie xxuejie left review comments

@15168316096 15168316096 15168316096 approved these changes

@XuJiandong XuJiandong XuJiandong approved these changes

@quake quake quake approved these changes

@jordanmack jordanmack Awaiting requested review from jordanmack jordanmack is a code owner automatically assigned from nervosnetwork/rfc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mohanson @quake @XuJiandong @xxuejie @15168316096 @zhangsoledad