Remove dependency and extendsFrom from ModModel DSL #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Should we add the evaluationDependsOn to the README? |
neoforged-automation
bot
added
the
needs rebase
|
@Technici4n, this pull request has conflicts, please resolve them for this PR to move forward. |
For now I added a check for duplicates, which should already catch some cases. |
Technici4n
force-pushed
the
remove-mods-dependency
branch
from
429c9ab
to
96f2624
Compare
neoforged-automation
bot
removed
the
needs rebase
shartte
approved these changes
Sep 1, 2024
|
🚀 This PR has been released as ModDevGradle version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #119.
Removed because they do not work in IDEs. Even worse, sometimes they might appear to work! For example, before this PR,
gradlew :jijtest:runDataon the testproject works. Now, if you run Data from the IDE it will works because the jar file got built. However, if you removecoremod/build/libs/coremod.jarand try running with the IDE again... then it fails!