Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a release #951

Closed
jgosmann opened this issue Apr 13, 2018 · 4 comments
Closed

Make a release #951

jgosmann opened this issue Apr 13, 2018 · 4 comments
Assignees

Comments

@jgosmann
Copy link
Collaborator

jgosmann commented Apr 13, 2018

Reasons:

  • Last release version won't start and fails with an exception (master works): (edit: apparently I had some weird version installed, but the other points still stand)
Traceback (most recent call last):
  File "/home/jgosmann/.pyenv/versions/3.6.1/bin/nengo", line 11, in <module>
    load_entry_point('nengo-gui==0.3.2.dev0', 'console_scripts', 'nengo')()
  File "/home/jgosmann/.pyenv/versions/3.6.1/lib/python3.6/site-packages/nengo_gui/main.py", line 117, in main
    s.start()
  File "/home/jgosmann/.pyenv/versions/3.6.1/lib/python3.6/site-packages/nengo_gui/gui.py", line 75, in start
    self.server.settings.prefix, self.server.auth_token))
TypeError: not all arguments converted during string formatting
@Seanny123
Copy link
Collaborator

Should a release be done before the Summer School?

@jgosmann
Copy link
Collaborator Author

jgosmann commented May 22, 2018

+1
Sent an email about this to @tcstewar and @Seanny123.

Main content copied below:

There is also a number of PRs that would be nice to have merged before:

Furthermore:

Not as relevant for the summer school, but nice to haves imo:

@jgosmann
Copy link
Collaborator Author

Two more PRs good to have:
#960 and #961

@tcstewar
Copy link
Collaborator

tcstewar commented Jun 1, 2018

Release made! I didn't get #921 in, or #959 and #860 .

Thank you to everyone, and especially to @jgosmann, for all the many fixes and improvements in this release, and for continuing to bug me to get things merged. :)

@tcstewar tcstewar closed this as completed Jun 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants