Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused variable in Namefinder? #615

Open
Seanny123 opened this issue Nov 18, 2015 · 2 comments
Open

Unused variable in Namefinder? #615

Seanny123 opened this issue Nov 18, 2015 · 2 comments
Assignees
@Seanny123
Labels
enhancement gui2-fixed server

Comments

@Seanny123
Copy link
Collaborator

The variable self.base_terms is never used anywhere in the code, despite being assigned from an argument. May I remove it?
@tcstewar
Copy link
Collaborator

Yup, that looks to be unused. I believe the initial reason for having that is that I was going to make namefinder work on an as-needed basis, rather than doing a complete search through the model upfront, but that never happened.

@Seanny123 Seanny123 self-assigned this Jun 6, 2016
@Seanny123
Copy link
Collaborator Author

This appears to be resolved in #806 which refactors parts of the backend. Will close once it merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Seanny123 Seanny123

Labels
enhancement gui2-fixed server
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Seanny123 @tcstewar @krisfrenette