Nullability and requiredness of a property gets ignored when using an attribute derived from \OpenApi\Attributes\Property

[egonolieux]

If a class has a nullable property:

final readonly class SomeObject
{
    public function __construct(
        public ?int $number,
    ) {}
}

The OpenAPI spec is generated correctly with nullable set to true:

"number": {
    "type": "integer",
    "nullable": true
}

However, when the number property has an attribute that is derived from the OpenAPI OpenApi\Attributes\Property class (where CustomOpenApiProperty is defined as final class CustomOpenApiProperty extends \OpenApi\Attributes\Property):

final readonly class SomeObject
{
    public function __construct(
        #[CustomOpenApiProperty()]
        public ?int $number,
    ) {}
}

The OpenAPI spec is generated without nullable:

"number": {
    "type": "integer",
    "x": [
        "someCustomData": "someCustomValue"
    ]
}

As I'm unfamiliar with the internals of this bundle, this might be a more general issue not specific to nullable.

---

Update: this issue also applies to the the property being required since #2111 was fixed.

[DerManoMann]

This might be more likely an issue in the underlying swagger-php library.

[egonolieux]

This might be more likely an issue in the underlying swagger-php library.

I think not, because using the OpenApi\Attributes\Property directly does not reproduce the issue. I suspect this might be caused by the merging logic of the describers somehow.

[DerManoMann]

Turns out you are right ;) - zircote/swagger-php#1466

Historically there have been cases in the library where code was checking for specific class types, but I think those should be all gone by now.