Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using a different release branch naming convention #231

Open
sourcedelica opened this issue Nov 9, 2022 · 0 comments
Open

Using a different release branch naming convention #231

sourcedelica opened this issue Nov 9, 2022 · 0 comments

Comments

@sourcedelica
Copy link

I'm porting an existing set of projects to use nebula-release-plugin. Historically their release branch naming convention is release-x.y, for example release-3.2. The nebulaRelease extension allows you to set releaseBranchPatterns and that is helpful in it won't allow you to release from other branch names. However, setting releaseBranchPatterns does not change the list of branch patterns in NetflixOssStrategies.getScopes. Those strategies determine the default handling of version increments for snapshot, final, etc. The README.md talks about this:

We attempt to pick up on the fact that you're on certain release branches.

Examples:

On release/1.x - The plugin will default to versioning you 1.0.0-SNAPSHOT
On 3.x - The plugin will default to versioning you 3.0.0-SNAPSHOT
On 4.2.x - The plugin will default to versioning you 4.2.0-SNAPSHOT

The default versioning only works if you use branch names ending with .x.

Is there way to use our legacy branch naming convention and get the versioning behavior of the ReleasePlugin? I supposed I could start with BaseReleasePlugin and configure new strategies that use our legacy branch naming, but there is a huge gap between the base plugin and ReleasePlugin. I really want all of the goodness in ReleasePlugin just with this little tweak :)

Either way, thanks! I've been testing the plugin and checking out the code over the last few days and it's really impressive. I'm thankful that it exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant