Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking Change included as a patch version #514

Closed
vidarc opened this issue Nov 20, 2024 · 4 comments · Fixed by #515
Closed

Breaking Change included as a patch version #514

vidarc opened this issue Nov 20, 2024 · 4 comments · Fixed by #515

Comments

@vidarc
Copy link

vidarc commented Nov 20, 2024

Due to #502 and the engines increase (from 16 => 20), the latest patch versions of this package should have been considered a breaking change. This dropping of support for Node <= 20 doesn't appear to be documented either.

specifically - https://github.com/nearform/fast-jwt/pull/502/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L80

@simoneb simoneb linked a pull request Nov 20, 2024 that will close this issue
@simoneb
Copy link
Member

simoneb commented Nov 20, 2024

Thanks for reporting. I've deprecated 4.0.6 and published 5.0.0.

@ilteoood be careful when making such changes, this semver major change was done in a PR whose semver tag was chore: #509

@ilteoood
Copy link
Contributor

Thanks for reporting. I've deprecated 4.0.6 and published 5.0.0.

@ilteoood be careful when making such changes, this semver major change was done in a PR whose semver tag was chore: #509

I thought it would check the content of each commit.
In fact, I added the breaking prefix where it has been made: 35e56cb

@simoneb
Copy link
Member

simoneb commented Nov 20, 2024

No, we check the semver tag of the merge commit generate from the title of the PR and use that in the notify release workflow #488

Copy link
Contributor

🎉 This issue has been resolved in version 5.0.1 🎉

The release is available on:

Your optic bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants