Variable naming is confusing

[Sliman4]

For example, reconstructSignature:

near-multichain/src/services/ethereum.js

Line 90 in 578ad9a

const signature = transaction.addSignature(v, r, s);

Here the variable name is called signature. Even though, it contains a signed transaction.
Then, it returns the variable named signature:

near-multichain/src/services/ethereum.js

Line 94 in 578ad9a

return signature;

And the method itself is called reconstructSignature, so it would make sense for it to return a signature. But no!

near-multichain/src/components/Ethereum/Ethereum.jsx

Line 78 in 578ad9a

const signedTransaction = await Eth.reconstructSignature(big_r, s, recovery_id, transaction, senderAddress);

Now it's signedTransaction when we use it in another file.

Second example:

near-multichain/src/services/ethereum.js

Line 67 in 578ad9a

const payload = transaction.getHashedMessageToSign();

The word payload is quite ambiguous by itself, one could argue that the serialized transaction that is sent to RPC is also a payload. So without much digging, it's easy to assume that here

near-multichain/src/components/Ethereum/FunctionCall.jsx

Lines 65 to 66 in 578ad9a

	const { transaction, payload } = await Eth.createPayload(senderAddress, contract, 0, data);
	return { transaction, payload };

it's just a transaction that is serialized. Or something entirely different, because why does it return 2 objects if the second can be derived from the first in 1 method call. Not everyone knows that you can't sign a transaction, you have to sign its hash. But maybe there could at least be a comment so that people who never worked with signatures at low level can get a grasp of it quicker.

There are probably more ambiguous names, I didn't check the whole example, was just helping someone get started with chain signatures and they were following this example.

[gagdiez]

changed names to a - hopefully - less confusing nomenclature, please open the issue again if the changes where not enough clear