Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't engineering mode #16

Open
DuanPhan92 opened this issue Nov 9, 2023 · 3 comments
Open

can't engineering mode #16

DuanPhan92 opened this issue Nov 9, 2023 · 3 comments

Comments

@DuanPhan92
Copy link

When I send command enableengineeringmode and I alway receive Enabling engineering mode: failed. Can you check it?

@tonhuisman
Copy link

For engineering mode to actually work you'll probably need the code from PR #3.
I've used that for a project, and it's mostly working fine, though I had to change a few bits to make it work with the way my project works, and I added a few undocumented features of the sensor.

@ncmreynolds
Copy link
Owner

I'm afraid I never finished implementing engineering mode. I may come back to it at some point,. PR #3 is huge, being effectively a complete rewrite that I found impractical to meaningfully review.

@tonhuisman
Copy link

As said, I am using that code, because it implements the engineering mode, and it is working quite well.

If desired, I can make a new PR here with all those changes, and what I added, that should be able to merge without conflicts? Most credits should go to skoona, I guess 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants