Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poor bugfix in bb98 function #46

Open
unicornsasfuel opened this issue Oct 15, 2016 · 0 comments
Open

Poor bugfix in bb98 function #46

unicornsasfuel opened this issue Oct 15, 2016 · 0 comments

Comments

@unicornsasfuel
Copy link
Contributor

I have no idea why, but as mentioned in #44 the bb98 algorithm as implemented would incorrectly identify the last bit of the message. Oddly, it also seems to have about 9 bytes of random junk at the beginning too. I've applied a hacky fix which just brute forces the correct message by waiting until the set of potential plaintexts is small enough to brute force reasonably, then does so. This provides a small performance increase, but I have no idea why this fix is necessary and as such it should be fixed properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant