Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Username is always lowercase #9

Open
phm46 opened this issue Apr 28, 2021 · 4 comments
Open

Username is always lowercase #9

phm46 opened this issue Apr 28, 2021 · 4 comments

Comments

@phm46
Copy link

phm46 commented Apr 28, 2021

Hey, thank you for this amazing plugin!

Today I've had problem with authorization in web application. Server stored usernames in uppercase, but plugin was sending lowercase. I've tried to change username to uppercase, but it still remained same. Then I looked in source code and discovered that it is always lowercase. When I modified line 464 and removed "toLowerCase" function it worked as expected.
It would be nice to have option to use username "as it is".

@rtt-ncc
Copy link
Collaborator

rtt-ncc commented Apr 29, 2021

Hi - thanks for your feedback and glad you are finding it useful!

I've never encountered this issue before - can I ask what the Kerberos technology in use is? I've never known Active Directory to care about case sensitivity of usernames. Is it something other than Windows you are testing?

It does sound like I need to add a case-sensitivity option for the username anyway....

@phm46
Copy link
Author

phm46 commented Apr 29, 2021

Well, to be exact.

Web application uses kerberos username as authorization mechanism for DMS system. Kerberos part in web application worked flawlessly. However, that web application also communicate with DMS system and that system is case sensitive. So when application called DMS system and used my username in headers, it used lowercase version I’ve sent. That was problem because DMS system didn’t recognized my username

@rtt-ncc
Copy link
Collaborator

rtt-ncc commented Apr 30, 2021

Thanks, that makes sense.
Obviously this is a bit of an edge case, but it would be an easy feature to add, so I'll hopefully include it in the next release (no timescale for that at the moment though unfortunately!)

@phm46
Copy link
Author

phm46 commented Apr 30, 2021

Yeah, I know. I just wanted to let you know about this.
No need to rush, I've fixed it by myself for this case :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants