Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build nuget packages in CI and push to nuget.org #28

Merged
merged 13 commits into from
Nov 25, 2024

Conversation

webwarrior-ws
Copy link
Collaborator

Description of Change

Build nuget packages for commits in "main" branch or tags
and upload to nuget.org.

For main branch, create pre-relaese packages, and for tags
create stable release packages.

Issues Fixed

Fixes #94

Build nuget packages for commits in "main" branch or tags
and upload to nuget.org.
@webwarrior-ws webwarrior-ws changed the base branch from master to main November 19, 2024 13:36
@webwarrior-ws webwarrior-ws force-pushed the fix-linux-maui-94-mali branch 2 times, most recently from 30459a9 to 4c763d4 Compare November 19, 2024 13:43
@knocte
Copy link
Member

knocte commented Nov 19, 2024

This should include a 4th commit (which we would not include in maui-linux PR) that renames all Maui*.* packages to Mali*.* before uploading to nuget.org.

Include GTK in Directory.Build.Override.props.in.
Update versions of packages that have vulnerability and block
the build.
@webwarrior-ws webwarrior-ws force-pushed the fix-linux-maui-94-mali branch 19 times, most recently from 35f5b05 to ec94a9f Compare November 20, 2024 13:25
Treat NU1605 warning (Detected package downgrade) not as error.
These are result of System.Text.Json upgrade in previous
commit. Also disable NU1605 warning because just adding it to
WarningsNotAsErrors is not sufficient.
As it doesn't exist in Mali/main.

- name: Run dotnet format
run: |
# remark: doesnt work, alwasy fails:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@webwarrior-ws typo ^ but wait, why did you add this dotnet format thing? looks unrelated

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied the whole build-gtk.yml file

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from where??

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from maui-linux

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you put this in commit msg? still, better to copy only what is relevant, we will pull from maui-linux last version when we need to and then we get all those things

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed dotnet-format job

pack_mali.sh Outdated Show resolved Hide resolved
@webwarrior-ws webwarrior-ws force-pushed the fix-linux-maui-94-mali branch 5 times, most recently from 03c07ce to 228665c Compare November 25, 2024 11:31
Rename Microsoft.Maui.* packages to Mali.* so they can be
published on nuget.org.
Some packages depend on Graphics, so publish it as well.
Similarly to how FSharpLint does it.
To publish first set of packages on nuget.org.
Revert previous commit and only publish packages from main.
Extract commands for installing GTK workload into
install_gtk_workload.sh script.
It is not relevant for current PR.
@knocte knocte merged commit c1564ed into nblockchain:main Nov 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nuget packages: prerelease for each commit and non-prerelease for each git tag? via GitHub Actions
2 participants