-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Binance Live Strategy cannot handle GTE_GTC order #1024
Comments
Looks like Binance returned a weird and undocumented (at least I can't find it) time in force value: ValidationError(Invalid enum value 'GTE_GTC' - at `$.data.o.f`) Do you regularly manually close positions, and it normally works? |
@cjdsellers not so frequently,current I have not find a good stop condition,so sometimes I leave open position with strategy and close position manually |
Understood, just trying to establish that Nautilus can normally handle this, when Binance sends a proper time in force? Last QA testing I did it was handling it well. |
What were the original order params you used (especially the time in force)? |
current using MarketOrder |
Thanks for the feedback, could you please let me know if you see this again when manually closing a position 🙏 . |
GTE_GTC//GoodTillExpiredOrCanceled NOT for Futures,this is not includ in binance document,but I find some form github code,maybe we need to add this to TimeInForce. |
@poshcoe How do you think we should handle this? |
A |
Agreed. |
Now fixed from 914d3cf on |
Bug Report
Binance Live Strategy cannot handle GTE_GTC order
Expected Behavior
Strategy should handler manual closed GTE_GTC order
Actual Behavior
Strategy cannot process position closed event feedback info.
Steps to Reproduce the Problem
1.Use binance future strategy to open a position and manually close it on phone or web with market stop loss order.
2.look at the logs.
Specifications
nautilus_trader
version: latest develop versionhere is the log
The text was updated successfully, but these errors were encountered: