Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix email address right-click ability #54

Open
stevegt opened this issue Apr 13, 2017 · 6 comments
Open

Fix email address right-click ability #54

stevegt opened this issue Apr 13, 2017 · 6 comments
Assignees

Comments

@stevegt
Copy link
Contributor

stevegt commented Apr 13, 2017

The consensus on the call this week was that the contact email address should be right-clickable to copy the address itself, rather than e.g. a gmail URL. It appears (as far as I can tell) that we're still doing something in the CSS to break this. (This behavior might be different, depending -- I'm seeing the breakage when using chrome and logged into gmail in another tab.)

For comparison, try right-clicking the same email address in the comments at the top of #50 -- that's the way we were talking about making it work during the phone call. It should simply copy the email address into the clipboard.

@placer14
Copy link
Contributor

email_copy_works

Please provide steps to reproduce.

@stevegt stevegt reopened this May 4, 2017
@placer14
Copy link
Contributor

placer14 commented May 4, 2017

Please provide the steps to reproduce, @stevegt. I see it working.

@stevegt
Copy link
Contributor Author

stevegt commented May 4, 2017

In my installation of Chrome on Linux, there is no "copy email address" option in the context menu. All I get is a "copy link address" option, which copies this to the clipboard:

https://mail.google.com/a/t7a.org/mail/?view=cm&fs=1&tf=1&[email protected]

By way of comparison, the following link right here, on github, does give me a "copy email address" option in the context menu: [email protected]

@stevegt
Copy link
Contributor Author

stevegt commented May 4, 2017

bad
good

@stevegt
Copy link
Contributor Author

stevegt commented May 4, 2017

I get the "Copy email address" option in incognito, so that will help narrow it down. Reassigning to myself 'cause I'm going to need to chase down why it's doing that, and make sure our CSS isn't confusing a popular extension.

@stevegt stevegt self-assigned this May 4, 2017
@placer14
Copy link
Contributor

placer14 commented May 4, 2017

I'm pretty confident there's no difference between the two implementations. Please let me know what you find.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants