Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for current sort value not showing in OS search dropdown #675

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

ltrasca
Copy link
Collaborator

@ltrasca ltrasca commented Nov 28, 2024

Changes in this PR

  • Removed mentions of build_sorting_orders in the search endpoints - these weren't needed anymore as we don't pass sorting to the query building functions in that format anymore
  • Replaced the sort list template reference on TB search page with a much simpler duplicate, isolated from the sorting on other types of templates. This now uses the sort variable passed to the template context - going forwards a refactor of the original template to use this simpler strategy would be ideal
  • Updated tests to reflect changes and removed the build_sorting_orders_open_search deprecated function

JIRA ticket

N/A

Screenshots of UI changes

N/A

  • Requires env variable(s) to be updated

@ltrasca ltrasca self-assigned this Nov 28, 2024
@ltrasca ltrasca merged commit 9215b16 into main Nov 29, 2024
7 checks passed
@ltrasca ltrasca deleted the os-sorting-bug-fix branch November 29, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants