Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ayr 1297/audit app logs #646

Merged
merged 20 commits into from
Nov 28, 2024
Merged

Ayr 1297/audit app logs #646

merged 20 commits into from
Nov 28, 2024

Conversation

colinbowen
Copy link
Collaborator

Changes in this PR

  • Update logger_config.py to include the new setup_logging function that configures app_logger and audit_logger and logging levels.
  • Update readme on usage of audit logger and app logger

JIRA ticket

https://national-archives.atlassian.net/browse/AYR-1297

Screenshots of UI changes

N/A

Before

After

  • Requires env variable(s) to be updated

@colinbowen colinbowen force-pushed the AYR-1297/audit-app-logs branch from f3da105 to 382c18a Compare November 18, 2024 11:48
@colinbowen colinbowen marked this pull request as ready for review November 21, 2024 12:16
app/main/routes.py Outdated Show resolved Hide resolved
@colinbowen
Copy link
Collaborator Author

  • Remove newly created log group and log streams and move to use a filter which is exported directly to S3.

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.29%. Comparing base (6693292) to head (e95284c).
Report is 62 commits behind head on main.

Files with missing lines Patch % Lines
app/main/util/render_utils.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #646      +/-   ##
==========================================
- Coverage   95.88%   94.29%   -1.60%     
==========================================
  Files          16       20       +4     
  Lines        1021     1174     +153     
==========================================
+ Hits          979     1107     +128     
- Misses         42       67      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@colinbowen colinbowen merged commit 5c07ba8 into main Nov 28, 2024
7 checks passed
@colinbowen colinbowen deleted the AYR-1297/audit-app-logs branch November 28, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants