Make current poc routes protected #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgandhizaizi
approved these changes
Oct 31, 2023
…ired_decorator.py
…ycloak_openid_object_from_aws_params and test get_keycloak_openid_object_from_aws_params
…un across all routes we expect to be covered by this decorator
…n for app/tests/test_keycloak_login_required_decorator.py
anthonyhashemi
force-pushed
the
make-current-poc-routes-protected
branch
from
6d5ac0b to
05ce2ae
Compare
anthonyhashemi
force-pushed
the
make-current-poc-routes-protected
branch
from
05ce2ae to
1edbfa3
Compare
anthonyhashemi
changed the title
anthonyhashemi
commented
Nov 2, 2023
anthonyhashemi
commented
Nov 2, 2023
anthonyhashemi
commented
Nov 2, 2023
…ed tests instead of a wrapping function
anthonyhashemi
force-pushed
the
make-current-poc-routes-protected
branch
from
caa3c05 to
0c0eb0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://national-archives.atlassian.net/browse/AYR-460
When doing some testing for some other work I realised that our POC login flow was broken and we weren't protecting the poc pages that contains data/should be protected. We need to do this before we deploy to sandbox at minimum.
Note: the flash messages show fine when not redirected, but when redirected they don't show on the redirected page, only on the one after that so need to fix that.
Changes in this PR