Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Isort install #19

Merged
merged 20 commits into from
Oct 27, 2023
Merged

Isort install #19

merged 20 commits into from
Oct 27, 2023

Conversation

colinbowen
Copy link
Collaborator

Changes in this PR

  • Add isort with a profile that supports black code formatting

JIRA ticket

Screenshots of UI changes

Before

After

  • Requires env variable(s) to be updated

colinbowen and others added 18 commits October 27, 2023 12:12
@colinbowen
feat: install isort to pre-commit
3061fde
@colinbowen
fix: remove demo code
b282954
@anthonyhashemi @colinbowen
Remove land registry license
3fb8222
@anthonyhashemi @colinbowen
Remove uneeded Keycloak ping and comment out broken code in routes file
84c2c1e
@anthonyhashemi @colinbowen
Add basic flask-pytest test for poc-search-view
c9e2d4e
@anthonyhashemi @colinbowen
Delete empty tests files
a9d4205
@anthonyhashemi @colinbowen
Delete example playwright test file
af78f48
@anthonyhashemi @colinbowen
Move playwright tests to dedicated e2e tests folder
2dceac2
@anthonyhashemi @colinbowen
Fallback to empty string, not None for Config attrs when no env var s…
afa9deb 
…et for unit tests
@anthonyhashemi @colinbowen
Add gh action workflow to run unit test on branch push and merge to main
27b50b3
@colinbowen
feat: install isort to pre-commit
afa43d2
@anthonyhashemi @colinbowen
Remove uneeded Keycloak ping and comment out broken code in routes file
309a170
@colinbowen
fix: isort
9b5fc37
@colinbowen
remove demo code
58e3d47
@colinbowen
sign commit
16aae87
@colinbowen
sign commit
6ada4f7
@colinbowen
Use python3 as black version
a5036e7
@colinbowen
merge main
20b803b
@colinbowen colinbowen merged commit c3b3422 into main Oct 27, 2023
7 checks passed
zaiziclebby pushed a commit that referenced this pull request Nov 8, 2023
@colinbowen
Merge pull request #19 from nationalarchives/isort-install
2f354d6 
Isort install
@anthonyhashemi anthonyhashemi deleted the isort-install branch January 4, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthonyhashemi anthonyhashemi anthonyhashemi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colinbowen @anthonyhashemi