-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write unit tests for service and characteristics classes #5
Labels
test coverage
Test coverage improvement
Comments
natersoz
added a commit
that referenced
this issue
Feb 10, 2019
natersoz
added a commit
that referenced
this issue
Feb 18, 2019
natersoz
added a commit
that referenced
this issue
Mar 17, 2019
Aggregate work: * Add free_lists to service_builder * Loosen up ble::gatt:attrbute types to deal with discovered properties. * gatt::characteristic, gatt::descriptor, gatt::service all get default ctors and are no longer const only data members. This way their uuids, types and associations can be changed as services are discovered. Add attribute_type::undefined for creating objects which do not yet know their attribute type. * Add service_container::find_service_handle_assoc() * Issue #21: overloaded non-const member functions should call const members * Add service_builder::discovery_iterator * nordic_ble_gattc_operations.cc add debug log messages to each call * Add external directory for 3rd party source and libraries. Has its own Makefile Executes download of Nordic SDK, googletest. Unzips/de-archive the compressed file format. For Nordic's SDK, execute nordic/sdk-modifiled/replace_sdk_files. * Implement unit tests within googletest Issue #6 * Add unit tests for service and characteristics classes Issue #5 * Add version info for BLE central, peripheral Version information consists of a version string built from a git tag (TBD) and the 4 left-hand bytes of the git sha1 (implemented). The version info struct is located at the top of FLASH in the section .version_info. * Device Information Service (DIS) Updated. Uses Nordic NRF_FICR->DEVICEADDR to create a unique 8-byte serial number. * Segger RTT buffer allocations provided by application Issue #30 Previously #define nonsense inside the header segger/segger_rtt_conf.h Now the application allocates the buffer and passes it in to the Segger RTT module. * Change namespace write_data -> io * Add io::output_stream* logger::get_output_stream() * Move discovery_iterator into service_container * Fix broken unit tests test_vwritef, test_write_data
natersoz
added a commit
that referenced
this issue
Mar 17, 2019
Aggregate work: * Add free_lists to service_builder * Loosen up ble::gatt:attrbute types to deal with discovered properties. * gatt::characteristic, gatt::descriptor, gatt::service all get default ctors and are no longer const only data members. This way their uuids, types and associations can be changed as services are discovered. Add attribute_type::undefined for creating objects which do not yet know their attribute type. * Add service_container::find_service_handle_assoc() * Issue #21: overloaded non-const member functions should call const members * Add service_builder::discovery_iterator * nordic_ble_gattc_operations.cc add debug log messages to each call * Add external directory for 3rd party source and libraries. Has its own Makefile Executes download of Nordic SDK, googletest. Unzips/de-archive the compressed file format. For Nordic's SDK, execute nordic/sdk-modifiled/replace_sdk_files. * Implement unit tests within googletest Issue #6 * Add unit tests for service and characteristics classes Issue #5 * Add version info for BLE central, peripheral Version information consists of a version string built from a git tag (TBD) and the 4 left-hand bytes of the git sha1 (implemented). The version info struct is located at the top of FLASH in the section .version_info. * Device Information Service (DIS) Updated. Uses Nordic NRF_FICR->DEVICEADDR to create a unique 8-byte serial number. * Segger RTT buffer allocations provided by application Issue #30 Previously #define nonsense inside the header segger/segger_rtt_conf.h Now the application allocates the buffer and passes it in to the Segger RTT module. * Change namespace write_data -> io * Add io::output_stream* logger::get_output_stream() * Move discovery_iterator into service_container * Fix broken unit tests test_vwritef, test_write_data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
These classes are hardware independent and would benefit from unit tests.
The text was updated successfully, but these errors were encountered: