Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coverage Test typos + bugs #445

Open
2 tasks done
thnkslprpt opened this issue Dec 11, 2024 · 0 comments · May be fixed by #446
Open
2 tasks done

Coverage Test typos + bugs #445

thnkslprpt opened this issue Dec 11, 2024 · 0 comments · May be fixed by #446

Comments

@thnkslprpt
Copy link
Contributor

Checklist

  • I reviewed the Contributing Guide.
  • I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
Test sets index '3' twice, and apparently passing now despite the typo as it's comparing zero against zero for index '4'.

PSP/unit-test-coverage/modules/ram_direct/coveragetest-ram_direct.c

Lines 151 to 167 in cdc73e5

void Test_CFE_PSP_MemRead32(void)
{
/* Test for:
int32 CFE_PSP_MemRead32(cpuaddr MemoryAddress, uint32 *uint32Value)
*/
uint32 Value1;
uint32 Value2;
cpuaddr UtAddress1;
cpuaddr UtAddress2;
UtAddress1 = (cpuaddr)&UT_RAM_BLOCK.u32[3];
UtAddress2 = (cpuaddr)&UT_RAM_BLOCK.u32[4];
UT_RAM_BLOCK.u32[3] = 0xAABBCCDD;
UT_RAM_BLOCK.u32[3] = 0x44556677;

There are a couple of other minor typos/bugs in the coverage tests.

Expected behavior
Correct tests/comments.

Reporter Info
Avi Weiss   @thnkslprpt
thnkslprpt added a commit to thnkslprpt/PSP that referenced this issue Dec 11, 2024
@thnkslprpt
Fix nasa#445, Coverage Test typos + bugs
0811425
@thnkslprpt thnkslprpt linked a pull request Dec 11, 2024 that will close this issue
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #445, Coverage Test typos + bugs thnkslprpt/PSP
1 participant
@thnkslprpt