Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #97, Update UT to handle DS_SEQUENCE_DIGITS configuration #98

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Mar 21, 2023

Checklist (Please check before submitting)

Describe the contribution

Testing performed
CI and ran with DS_SEQUENCE_DIGITS of 4

Expected behavior changes
Won't fail for changed DS_SEQUENCE_DIGITS

System(s) tested on
Ubuntu 20.04

Additional context
None

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

Copy link
Contributor

@jphickey jphickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm generally OK with this for now however we should watch out that using StrFormat like this tends to trigger some static analysis warnings about using a non-const format string. It might come back again and need a different fix if that happens.

@dzbaker dzbaker merged commit de6ef6f into nasa:main Mar 23, 2023
@dmknutsen dmknutsen added this to the Equuleus milestone May 26, 2023
@skliper skliper deleted the fix97_sequencedigitsut branch April 1, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit test breaks on DS_SEQUENCE_DIGITS configuration change
5 participants