Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test breaks on DS_SEQUENCE_DIGITS configuration change #97

Closed
3 tasks done
skliper opened this issue Mar 21, 2023 · 0 comments · Fixed by #98
Closed
3 tasks done

Unit test breaks on DS_SEQUENCE_DIGITS configuration change #97

skliper opened this issue Mar 21, 2023 · 0 comments · Fixed by #98
Assignees
Milestone

Comments

@skliper
Copy link
Contributor

skliper commented Mar 21, 2023

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I reviewed the README file to see if the feature is in the major future work.
  • I performed a cursory search to see if the feature request is relevant, not redundant, nor in conflict with other tickets.

Is your feature request related to a problem? Please describe.
Unit test assumes default config for DS_SEQUENCE_DIGITS, fails any customization.

#define DS_SEQUENCE_DIGITS 8

char StrCompare[] = "path/base00000001.ext";

char StrCompare[] = "path/base00000001.ext";

char StrCompare[] = "path/base00000001.ext";

char StrCompare[] = "path/base00000001";

UtAssert_UINT32_EQ(strncmp(Sequence, "00000001", DS_TOTAL_FNAME_BUFSIZE), 0);

Describe the solution you'd like
Built the test strings based on actual config, or otherwise improve result verification.

Describe alternatives you've considered
None.

Additional context
Likely an issue with default configuration changes all over cFS, but should at least move in the direction of unit tests that support valid configuration ranges.

Requester Info
Jacob Hageman - NASA/GSFC

@skliper skliper self-assigned this Mar 21, 2023
dzbaker added a commit that referenced this issue Mar 23, 2023
Fix #97, Update UT to handle DS_SEQUENCE_DIGITS configuration
@dmknutsen dmknutsen added this to the Equuleus milestone May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants