strncpy source sizeof

[superolmo]

Checklist (Please check before submitting)

• I reviewed the Contributing Guide.
• I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
While building with -Werror=sizeof-pointer-memaccess flag the compiler complains about "error: argument to ‘sizeof’ in ‘strncpy’ call is the same expression as the source; did you mean to use the size of the destination?"

To Reproduce
Steps to reproduce the behavior:

1. Add -Werror=sizeof-pointer-memaccess flag to compiler
2. Build

Expected behavior
No errors

Code snips

DS/fsw/src/ds_file.c

Line 886 in ce98853

strncpy(FileStatus->FileName, PathName, sizeof(PathName));

System observed on:

• OS: Oracle Linux 8.7

Additional context
N/A

Reporter Info
Claudio Olmi - NASA/METECS

[jphickey]

Yep, this is wrong. Thanks for pointing it out.

[pepepr08]

I also had this error on my project. I'll submit the fix