Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DS_AppProcessCmd - cyclomatic complexity of 20 #84

Closed
3 tasks done
chillfig opened this issue Mar 1, 2023 · 1 comment
Closed
3 tasks done

DS_AppProcessCmd - cyclomatic complexity of 20 #84

chillfig opened this issue Mar 1, 2023 · 1 comment

Comments

@chillfig
Copy link
Contributor

chillfig commented Mar 1, 2023

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I reviewed the README file to see if the feature is in the major future work.
  • I performed a cursory search to see if the feature request is relevant, not redundant, nor in conflict with other tickets.

Is your feature request related to a problem? Please describe.
NASA guidelines in NPR 7150.2D recommends maintaining a cyclomatic complexity in software, in particular flight software of 15. ds_app.c::DS_ProcessCmd unnecessarily violates the recommendation with a cyclomatic complexity of 20.

Describe the solution you'd like
Clean up DS_ProcessCmd such that it has a cyclomatic complexity of 15 or less.

Describe alternatives you've considered
N/A

Additional context
N/A

Requester Info
Justin Figueroa, Vantage Systems

@chillfig
Copy link
Contributor Author

chillfig commented Mar 1, 2023

This is desired implementation of command handlers. The switch statements in question are maximally simplistic as they represent each DS command. Function is very readable and to update would likely incur more risk or make less readable.

@chillfig chillfig closed this as not planned Won't fix, can't repro, duplicate, stale Mar 1, 2023
@dmknutsen dmknutsen added this to the Equuleus milestone May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants