Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes running the fuzzer causes assertion failures #8

Closed
kenballus opened this issue Feb 2, 2024 · 3 comments
Closed

Sometimes running the fuzzer causes assertion failures #8

kenballus opened this issue Feb 2, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@kenballus
Copy link
Collaborator

Every once in a while, especially if the Garden has just started, running the fuzzer will cause an assertion failure. This assertion is the one that ensures that the coverage information collected is not out of date.

@kenballus kenballus changed the title Figure out why sometimes funning the fuzzer causes assertion failures [BUG] Sometimes running the fuzzer causes assertion failures Feb 3, 2024
@kenballus kenballus added the bug Something isn't working label Feb 14, 2024
@kenballus kenballus changed the title [BUG] Sometimes running the fuzzer causes assertion failures Sometimes running the fuzzer causes assertion failures Feb 14, 2024
@kenballus
Copy link
Collaborator Author

Right now I catch this and encourage the user to reload the fuzzer. In the future, I should really figure this out :)

@pajod
Copy link
Contributor

pajod commented May 23, 2024

I hit that a lot.. appears recoverable in <=3 retries_left once the counter is correct after the next kill(SIGUSR1)

- dump_count = f.read(1)[0]
+ if bite := f.read(1):
+     dump_count = bite[0]
+ else:
+     return None
  if dump_count != server.dump_count % 256:
-     dump_count = server.dump_count
+     server.dump_count = dump_count + 1
      return None

That is what the assignment preceding return was intended for, right?
https://github.com/narfindustries/http-garden/blob/4b8e990/tools/fanout.py#L86-L87

@kenballus kenballus pinned this issue Sep 12, 2024
@kenballus
Copy link
Collaborator Author

I am overhauling all of this logic. I'm closing this issue (because for now coverage collection is removed, not because the issue is actually fixed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants