This repository has been archived by the owner on Sep 17, 2019. It is now read-only.
Fix #127 get_interfaces_ip fails when multiple ipv6 #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 similar comments
|
I think we should just defer this until after reunification and I can re-add or review it then. |
|
Will re-implement post-reunification. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix #127
I've deleted the secondary section. I guess this was copied from ipv4 section ? I didn't found a way to configure a secondary on an interface in 7.0.3.I7.1
If I'm mistaken and this is actually possible, could someone add some mocked_data to test it ?