Add support for xt db basis #56
Conversation
|
@alexandrasp You don't need to manually create the protobufs, you can just add them to https://github.com/naomijub/gXTDB/blob/main/resources/service.proto as Request and Response data structures, create a service that handles them then execute |
- define protobuf for db-basis - add server and client sides for db-basis Signed-off-by: Alexandra Pereira <[email protected]>
alexandrasp
force-pushed
the
add-support-for-xt-db-basis
branch
from
c69cf35 to
8a81110
Compare
quick and easy 🥇 |
Signed-off-by: Alexandra Pereira <[email protected]>
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #56 +/- ##
==========================================
+ Coverage 70.98% 71.11% +0.12%
==========================================
Files 6 6
Lines 224 225 +1
==========================================
+ Hits 159 160 +1
Misses 65 65
☔ View full report in Codecov by Sentry. |
alexandrasp
force-pushed
the
add-support-for-xt-db-basis
branch
2 times, most recently
from
98e45aa to
91369cb
Compare
alexandrasp
force-pushed
the
add-support-for-xt-db-basis
branch
from
91369cb to
cd8cc94
Compare
alexandrasp
force-pushed
the
add-support-for-xt-db-basis
branch
2 times, most recently
from
4514f39 to
2798e7f
Compare
alexandrasp
force-pushed
the
add-support-for-xt-db-basis
branch
from
2798e7f to
6b9ff37
Compare
|
|
||
| (defn db-basis->proto [db-basis-response] |
There was a problem hiding this comment.
I think this change broke stuff, I would probably test it with duplication for now
There was a problem hiding this comment.
also, db-basis->proto and ->db-basis are different things and had different usages
src/gxtdb/controllers.clj
Outdated
| @@ -19,12 +19,12 @@ | |||
|
|
|||
| (defn entity-tx [xtdb-node params] | |||
| (let [id (->id (:id-type params) (:entity-id params)) | |||
| db-basis (->db-basis params) | |||
| db-basis (adapters.db/db-basis->proto params) | |||
There was a problem hiding this comment.
I would checkout src/gxtdb and start fresh
There was a problem hiding this comment.
Ok! I reverted ->db-basis, and now the tests are passing. Now, going to check src/gxtdb
Signed-off-by: Alexandra Pereira <[email protected]>
No description provided.