feat: Add MAX_PAYMENTS_PER_INVOICE

nanopay · Sep 15, 2024 · 2d32a6b · 2d32a6b
1 parent 4796ad6
commit 2d32a6b
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/src/constants.ts b/src/constants.ts
@@ -3,3 +3,4 @@ export const INVOICE_MIN_AMOUNT = 0.00001;
 export const WEBHOOK_DELIVERY_TIMEOUT = 15000; // 15 seconds
 export const INVOICE_EXPIRATION = 1000 * 60 * 10; // 10 minutes
 export const MAX_WEBSOCKET_SESSIONS_PER_PAYMENT_NOTIFIER = 10;
+export const MAX_PAYMENTS_PER_INVOICE = 10;
diff --git a/src/durable/payment-listener.ts b/src/durable/payment-listener.ts
@@ -3,7 +3,7 @@ import NanoWebsocket, { SendEvent } from '../nano/websocket';
 import { Invoice, MessageBody, Payment, Service, Webhook } from '../types';
 import { rawToNano } from '../utils';
 import { logger } from '../logger';
-import { INVOICE_MIN_AMOUNT } from '../constants';
+import { INVOICE_MIN_AMOUNT, MAX_PAYMENTS_PER_INVOICE } from '../constants';
 import { PaymentNotifier } from './payment-notifier';
 
 export class PaymentListener extends DurableObject<Env> {
@@ -116,6 +116,12 @@ export class PaymentListener extends DurableObject<Env> {
 		if (paid_total >= invoice.price) {
 			await this.removePendingInvoice(invoice.id, invoice.pay_address);
 			await this.paymentReceiver(payments, invoice);
+		} else if (payments.length >= MAX_PAYMENTS_PER_INVOICE) {
+			await this.removePendingInvoice(invoice.id, invoice.pay_address);
+			logger.warn(`Max payments reached for invoice: ${invoice.id}`, {
+				invoice,
+				payments,
+			});
 		}
 	}
 

diff --git a/src/durable/payment-notifier.ts b/src/durable/payment-notifier.ts
@@ -1,6 +1,6 @@
 import { DurableObject } from 'cloudflare:workers';
 import { logger } from '../logger';
-import { MAX_WEBSOCKET_SESSIONS_PER_PAYMENT_NOTIFIER } from '../constants';
+import { MAX_PAYMENTS_PER_INVOICE, MAX_WEBSOCKET_SESSIONS_PER_PAYMENT_NOTIFIER } from '../constants';
 
 export type PaymentNotification = {
 	from: string;
@@ -84,7 +84,7 @@ export class PaymentNotifier extends DurableObject<Env> {
 
 		// Load the last 10 payments from the history stored on disk, and send them to the
 		// client.
-		const payments = await this.storage.list<Record<any, any>>({ reverse: true, limit: 10, prefix: 'payment_' });
+		const payments = await this.storage.list<Record<any, any>>({ reverse: true, limit: MAX_PAYMENTS_PER_INVOICE, prefix: 'payment_' });
 		[...payments.values()].forEach((value) => {
 			webSocket.send(JSON.stringify(value));
 		});