-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Astrometry faster & avoid long double operations where possible #1743
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhisrkckl
changed the title
Avoid long double operations as much as possible
Make Astrometry faster
Apr 24, 2024
abhisrkckl
changed the title
Make Astrometry faster
Make Astrometry faster & avoid long double operations where possible
Apr 24, 2024
abhisrkckl
added
the
awaiting review
This PR needs someone to review it so it can be merged
label
Apr 24, 2024
Have you verified that going to float instead of long double doesn't change precision? |
dlakaplan
reviewed
Apr 25, 2024
dlakaplan
reviewed
Apr 25, 2024
Closing this because the effects of the two separate changes are difficult to test together. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid creating
SkyCoord
objects during Astrometry computations. This was partly implemented in #1646 for models with proper motion. This PR does the same thing for cases without proper motion. This has a significant performance advantage.Also, avoid long double operations where possible. This is done by including a new column
tdbfloat
in the TOAs table. This is the same thing astdbld
, but reduced to float64 precision.Includes some refactorings suggested by sourcery.