Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Astrometry faster & avoid long double operations where possible #1743

Closed
wants to merge 26 commits into from

Conversation

abhisrkckl
Copy link
Contributor

@abhisrkckl abhisrkckl commented Apr 24, 2024

Avoid creating SkyCoord objects during Astrometry computations. This was partly implemented in #1646 for models with proper motion. This PR does the same thing for cases without proper motion. This has a significant performance advantage.

Also, avoid long double operations where possible. This is done by including a new column tdbfloat in the TOAs table. This is the same thing as tdbld, but reduced to float64 precision.

Includes some refactorings suggested by sourcery.

@abhisrkckl abhisrkckl changed the title Avoid long double operations as much as possible Make Astrometry faster Apr 24, 2024
@abhisrkckl abhisrkckl changed the title Make Astrometry faster Make Astrometry faster & avoid long double operations where possible Apr 24, 2024
@abhisrkckl
Copy link
Contributor Author

abhisrkckl commented Apr 24, 2024

Profiling test
(using the NGC6440E example dataset.)

Before

image

After

image

i.e., a 48% reduction in execution time.

@abhisrkckl abhisrkckl added the awaiting review This PR needs someone to review it so it can be merged label Apr 24, 2024
@dlakaplan
Copy link
Contributor

Have you verified that going to float instead of long double doesn't change precision?

@abhisrkckl
Copy link
Contributor Author

Closing this because the effects of the two separate changes are difficult to test together.
I'll make separate PRs for each.

@abhisrkckl abhisrkckl deleted the avoid_ld branch May 14, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review This PR needs someone to review it so it can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants