Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a meta attribute to the TimingModel #1873

Closed
JPGlaser opened this issue Dec 12, 2024 · 2 comments
Closed

Add a meta attribute to the TimingModel #1873

JPGlaser opened this issue Dec 12, 2024 · 2 comments
Assignees

Comments

@JPGlaser
Copy link

Hey All,

Currently, pint_pal is pinned at version 1.0.1 because we have a few places where we store metadata about the TimingModel object as direct attributes. This is no longer valid in version 1.1. As discussed on the 12/12 telecon, a quick fix would be to make a new meta attribute which is a dictionary. This would allow users to add metadata to the TimingModel without directly affecting the model itself in possibly weird ways.

See Tests found here:
https://github.com/nanograv/pint_pal/actions/runs/12300670688/job/34329402278?pr=94

~ Joe G.

@paulray
Copy link
Member

paulray commented Dec 12, 2024

Yeah the CHANGELOG for 1.0.2 has this, which must be the cause:

  • Doing model.par = something will try to assign to par.quantity or par.value but will give warning

@abhisrkckl
Copy link
Contributor

Added in #1874

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants