Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLDMNoise doesn't work correctly with wideband TOAs #1660

Open
abhisrkckl opened this issue Oct 23, 2023 · 3 comments · May be fixed by #1868 or #1869
Open

PLDMNoise doesn't work correctly with wideband TOAs #1660

abhisrkckl opened this issue Oct 23, 2023 · 3 comments · May be fixed by #1868 or #1869

Comments

@abhisrkckl
Copy link
Contributor

PLDMNoise is a GP representation of DM variations. Hence, while computing the wideband residuals, it should be applied to both TOAs and DMs. However, we don't have the framework to do this properly for a correlated noise component, and thus PLDMNoise is only applied to TOAs. This will lead to wrong results while analyzing wideband data.
@abhisrkckl
Copy link
Contributor Author

@blarsen10

@blarsen10
Copy link
Contributor

My limited understanding of the other DM modeling features in PINT is that the DispersionDM and DispersionDMX classes apply only to ToAs, while the ScaleDmError and DispersionJump classes apply only to wideband DMs. My intention when adding PLDMNoise was that it would behave similarly to DispersionDM and DispersionDMX, which means applying to ToAs but not wideband DMs. However, if my understanding is wrong and the DispersionDM and DispersionDMX classes also work with wideband ToAs, then maybe PLDMNoise should also do so in a similar way. Is that the case here? Or is there some other reason why this PLDMNoise should be made to work with wideband DMs? Apologies that I am not up to speed on the requirements for wideband analyses right now.

@abhisrkckl abhisrkckl mentioned this issue Dec 25, 2023
Merged
This was referenced Dec 5, 2024
Open
Open
@abhisrkckl abhisrkckl linked a pull request Dec 9, 2024 that will close this issue
WIP: Fitting for wideband datasets in the presence of correlated noise #1869
Open
@abhisrkckl
Copy link
Contributor Author

I am working with @vhaasteren on doing this properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@abhisrkckl @blarsen10