Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up ECORR code using fastshermanmorrison #1773

Open
abhisrkckl opened this issue May 29, 2024 · 2 comments
Open

Speed up ECORR code using fastshermanmorrison #1773

abhisrkckl opened this issue May 29, 2024 · 2 comments

Comments

@abhisrkckl
Copy link
Contributor

The package in question is https://github.com/nanograv/fastshermanmorrison written by @vhaasteren.

It implements the Sherman-Morrison lemma computation that's needed while computing the GLS chi2 when ECORRs are present. It's a major performance bottleneck in PINT right now. Since this package is written in Cython and a bit of straight-up C, it should offer significant speedup.

This package is pip and conda-installable according to its README file, so there is no issue with dependency management.

@vhaasteren
Copy link
Member

vhaasteren commented May 29, 2024

I would have to work a bit to make fastshermanmorrison conda-installable. I did just figure out how to do a conda forge release for PTMCMCSampler, so I could make an effort. Right now it is not yet in conda-forge.

@dlakaplan
Copy link
Contributor

For the moment PINT needs intel processors, so the ARM issue may not affect us here.

FWIW I did just install and test on a M1 Mac but with an Intel conda installation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants