Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TimingModel validation based on TOAs #1739

Open
abhisrkckl opened this issue Apr 19, 2024 · 0 comments
Open

TimingModel validation based on TOAs #1739

abhisrkckl opened this issue Apr 19, 2024 · 0 comments

Comments

@abhisrkckl
Copy link
Contributor

There are checks we can do to ensure that the user is not accidentally using the wrong par/tim combination, like START, FINISH, NTOAS, DMDATA, etc.

We can also validate some of the TimingModel components based on the given TOAs object:

  1. DMJump should not be used with narrowband TOAs
  2. PLDMNoise does not work properly with wideband TOAs
  3. If any of the TOAs have a terrestrial observatory, an Astrometry component should be present,
    etc...

We can emit warnings for such things from the get_model_and_toas() function or the constructor of the Residuals class.

See also discussion in #1731.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants