Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PINT special-cases parameters #1246

Closed
aarchiba opened this issue May 17, 2022 · 1 comment
Closed

PINT special-cases parameters #1246

aarchiba opened this issue May 17, 2022 · 1 comment

Comments

@aarchiba
Copy link
Contributor

Certain parameters, in particular DMDATA and START/FINISH are treated specially by PINT - that is, START/FINISH are explicitly checked to ensure that they are never fit for, and DMDATA is a boolParameter but its output (and no other boolParameter) is overridden to be 0/1 instead of the usual Y/N for TEMPO compatibility. These special cases should be set up as options on the Parameter objects when they are created, so that (for example) when the START parameter is created one can ensure that it is never fittable, without the rest of PINT needing to treat START specially.

These two changes are introduced in #1230, which is otherwise rather badly needed, so this issue is here to remind us to fix the temporary hack.

@abhisrkckl
Copy link
Contributor

This issue was solved as a side effect of #1640.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants