-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(documentation): update all supported node version in README.md #28
base: master
Are you sure you want to change the base?
fix(documentation): update all supported node version in README.md #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor sorting issue to resolve - comments inline - and only one other issue. Please, here and in your boxfile.yml
s, drop the revision number from all version strings. Major and minor are plenty for Node; some things only need the major. Most things shouldn't include a version number at all, but Node isn't one of them.
Anyway. Drop the revision parts of all the versions here, fix the sorting, and otherwise it looks good from here.
de3521d
to
81b9c64
Compare
Still need to drop revision numbers, but the sort looks better. |
Hum, what do you mean by drop revision numbers. I just checked, there is no |
Version numbers for Semantic Verisoned projects, like Node, consist of a few parts. Namely, The Nanobox packages for NodeJS include Major, Minor, Revision, and sometimes Tag values in their version numbers, but |
Got it, so actually I don't need to do anything on this pull request. |
About versioning, I actually use this package for my personal project. It can be a great idea to add it to this repository. |
@arnaud-zg Um, no, that's not what I was saying at all. Where you have Is that clearer? |
Ooh okay, it's done. 😸 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
@danhunsaker Lets merge it, we need it |
Any news ? |
Linked issue #27