Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: XOr behaves like Xor (should raise error) #487

Open
1 of 2 tasks
eeeeeecsh opened this issue Oct 14, 2024 · 3 comments
Open
1 of 2 tasks

[bug]: XOr behaves like Xor (should raise error) #487

eeeeeecsh opened this issue Oct 14, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@eeeeeecsh
Copy link

Tool

Hardware Simulator

Interface

Website (https://nand2tetris.github.io/web-ide)

Contact Details

No response

What happened?

When I wrongly typed "XOr" where I should type "Xor", it can still run successfully (without raising any error) as the chip "XOr" work just like Xor.
But in the desktop version of the hardware simulator, the same code will get an error like "In HDL file XOr.hdl, Line 9, Chip name doesn't match the HDL name: load HalfAdder.hdl"
Below is an example of this bug.
picture
I've also tried other similar typos like "XOR", only "XOr" behaves wrongly (others will raise an error as they should)

Additional Comments

No response

Do you want to try to fix this bug?

  • I want to try to add this feature!

Code of Conduct

  • I agree to follow this project's Code of Conduct
@eeeeeecsh eeeeeecsh added the bug Something isn't working label Oct 14, 2024
@DavidSouther
Copy link
Collaborator

@netalondon do you want to look into this? I wonder if we accidentally have a built in chip named "XOr" left over somewhere.

@DavidSouther
Copy link
Collaborator

Confirmed - in earlier versions of the web IDE, the chip was incorrectly named XOr. So if you loaded it both before and after that point, your IDE will have both Xor and XOr as builtin chips.

@DavidSouther
Copy link
Collaborator

We'll add a step to remove the XOr chip when you next load the IDE.

@DavidSouther DavidSouther self-assigned this Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants