Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to ndn-cxx segment fetcher #13

Open
pulsejet opened this issue Mar 29, 2023 · 3 comments
Open

Switch to ndn-cxx segment fetcher #13

pulsejet opened this issue Mar 29, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@pulsejet
Copy link
Collaborator

This may need changes to the spec, but is much more maintainable.

@pulsejet pulsejet added the enhancement New feature or request label Mar 29, 2023
@yoursunny
Copy link
Member

may need changes to the spec

You should never change a protocol to fit an implementation.
Instead, extend the segment fetcher to support the protocol.

@Pesa
Copy link
Member

Pesa commented Apr 5, 2023

You should never change a protocol to fit an implementation.

I don't think that's what's happening here. SegmentFetcher embodies a protocol (or convention) that is not specific to one implementation. My interpretation of this issue is simply to adjust the SVS spec as needed to conform to the SegmentFetcher conventions, which makes a lot of sense if we're talking about segmented objects.

@pulsejet
Copy link
Collaborator Author

pulsejet commented Apr 6, 2023

Yeah, the current spec is rather simplistic and patches multi-segment support on top of the previous protocol. So it is probably worth investigating a more consistent naming convention with a new protocol version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants