Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug on editor ui #11856

Open
zhiru opened this issue Nov 23, 2024 · 7 comments
Open

Bug on editor ui #11856

zhiru opened this issue Nov 23, 2024 · 7 comments
Labels
in linear Issue or PR has been created in Linear for internal review

Comments

@zhiru
Copy link

zhiru commented Nov 23, 2024

Bug Description

on https i have a problem on editor that i don`t know how to solve it, even changing the version

image

To Reproduce

  1. access using https on self hosted docker

Expected behavior

Works like using without https:

image

Operating System

Almalinux 8

n8n Version

1.68.0

Node.js Version

node 20

Database

PostgreSQL

Execution mode

queue

@Joffcom
Copy link
Member

Joffcom commented Nov 23, 2024

Hey @zhiru,

We have created an internal ticket to look into this which we will be tracking as "GHC-481"

@Joffcom Joffcom added the in linear Issue or PR has been created in Linear for internal review label Nov 23, 2024
@Joffcom
Copy link
Member

Joffcom commented Nov 23, 2024

Hey @zhiru

I have 3 possible thoughts on this one.

  1. Clear the browser cache and see if that sorts it out.

  2. Check the configuration of your reverse proxy, if it works without https the issue is likely in the middle.

  3. Make sure you are not using Cloudflare with caching.

@zhiru
Copy link
Author

zhiru commented Nov 23, 2024

Tks @Joffcom

  1. was the first one who did this

I'll try the others, but Cloudflare is not because I always disabled the proxy, but now I'm forcing development mode

late i came to say if works

@zhiru
Copy link
Author

zhiru commented Nov 23, 2024

i`m back, but none worked, know a i remember that i have another domain that appoints do docker too...

https://webhookn8n.aireset.com.br (with ssl and working):
image

https://n8n.aireset.com.br/ (with ssl and bugged editor view)

@Joffcom
Copy link
Member

Joffcom commented Nov 23, 2024

Hey @zhiru

Are they both pointing to the same n8n instance?

The second url hits a plesk page so it could that you have webhook_url pointing to one domain, editor_url pointing to the other and the load balancer not configured correctly.

@zhiru
Copy link
Author

zhiru commented Nov 23, 2024

yes, both are a docker in plesk, with proxy, now both are buggy haha

docker-compose.yml:

x-n8n-base: &n8n-base
env_file: ./.env
image: n8nio/n8n:1.68.0
restart: always
environment:
DB_TYPE: postgresdb
DB_POSTGRESDB_HOST: ${N8N_POSTGRES_HOST}
DB_POSTGRESDB_PORT: ${N8N_POSTGRES_INTERNAL_PORT}
DB_POSTGRESDB_DATABASE: ${N8N_POSTGRES_DATABASE}
DB_POSTGRESDB_USER: ${N8N_POSTGRES_USER}
DB_POSTGRESDB_PASSWORD: ${N8N_POSTGRES_PASSWORD}
DATA_FOLDER: ${N8N_DATA_FOLDER}
SUBDOMAIN: 'n8n'
links:
- n8n-postgres
- n8n-redis
volumes:
- n8n:/home/node/.n8n
networks:
- aireset-all-containers
depends_on:
n8n-redis:
condition: service_healthy
n8n-postgres:
condition: service_healthy

n8n:
<<: *n8n-base
hostname: $N8N_HOST_NAME
ports:
- $N8N_EXTERNAL_PORT:$N8N_INTERNAL_PORT
deploy:
mode: replicated
replicas: 1
placement:
constraints:
- node.role == manager
resources:
limits:
cpus: "1"
memory: $N8N_MEMORY_LIMIT

n8n-webhook:
<<: *n8n-base
hostname: $N8N_WEBHOOK_HOST_NAME
command: webhook
deploy:
mode: replicated
replicas: 2
placement:
constraints:
- node.role == manager
resources:
limits:
cpus: "2"
memory: $N8N_WEBHOOK_MEMORY_LIMIT

n8n-worker:
<<: *n8n-base
hostname: $N8N_WORKER_HOST_NAME
command: worker --concurrency=5
depends_on:
- n8n
- n8n-webhook
deploy:
mode: replicated
replicas: 2
placement:
constraints:
- node.role == manager
resources:
limits:
cpus: "2"
memory: $N8N_WORKER_MEMORY_LIMIT

--------------------------------------------------------

.env:

N8N_HIRING_BANNER_ENABLED=false
N8N_REINSTALL_MISSING_PACKAGES=true

N8N_CONTAINER_NAME="n8n.${DOMAIN}"
N8N_HOST_NAME="n8n.${DOMAIN}"
N8N_WEBHOOK_HOST_NAME="webhookn8n.${DOMAIN}"
N8N_WORKER_HOST_NAME="workn8n.${DOMAIN}"

N8N_MEMORY_LIMIT=2048M
N8N_WEBHOOK_MEMORY_LIMIT=2048M
N8N_WORKER_MEMORY_LIMIT=2048M

N8N_DEFAULT_LOCALE="en"

N8N_DATA_FOLDER="./data/n8n/data"

N8N_HOST="n8n.${DOMAIN}"

N8N_PROTOCOL="http" # changed because of bug
N8N_EDITOR_BASE_URL="http://${DOMAIN}" # changed because of bug
WEBHOOK_URL="http://webhookn8n.${DOMAIN}" # changed because of bug

N8N_SECURE_COOKIE=false
N8N_BASIC_AUTH_ACTIVE=true

GENERIC_TIMEZONE=${TZ}

SSL_EMAIL=${EMAIL}

N8N_EMAIL_MODE=smtp
N8N_SMTP_SENDER=${MAILER_SENDER_EMAIL}
N8N_SMTP_HOST=${SMTP_ADDRESS}
N8N_SMTP_PORT=${SMTP_PORT}
N8N_SMTP_USER=${SMTP_USERNAME}
N8N_SMTP_PASS=${SMTP_PASSWORD}
N8N_SMTP_SSL=true

EXECUTIONS_MODE=queue

EXECUTIONS_DATA_SAVE_ON_ERROR=all
EXECUTIONS_DATA_SAVE_ON_SUCCESS=all
EXECUTIONS_DATA_SAVE_ON_PROGRESS=all
EXECUTIONS_DATA_SAVE_MANUAL_EXECUTIONS=all
EXECUTIONS_TIMEOUT=160
EXECUTIONS_TIMEOUT_MAX=300

N8N_DEFAULT_BINARY_DATA_MODE=filesystem

EXECUTIONS_DATA_PRUNE=true
EXECUTIONS_DATA_MAX_AGE=336
EXECUTIONS_DATA_PRUNE_MAX_COUNT=5000

N8N_CONCURRENCY_PRODUCTION_LIMIT=10

--------------------------------------------------------

Apache/LiteSpeed Proxy:

SSLProxyEngine On
ProxyPreserveHost On
ProxyRequests Off
ProxyTimeout 36000
AllowEncodedSlashes NoDecode
HttpProtocolOptions Unsafe

SetEnvIfNoCase ^Authorization$ "(.+)" HTTP_AUTHORIZATION=$1
SetEnvIfNoCase ^Upgrade$ "(.+)" HTTP_UPGRADE=$1
SetEnvIfNoCase ^Connection$ "(.+)" HTTP_CONNECTION=$1
SetEnvIfNoCase ^Host$ "(.+)" HTTP_HOST=$1
SetEnvIfNoCase ^X-Forwarded-Proto$ "(.+)" HTTP_X_FORWARDED_PROTO=$1
SetEnvIfNoCase ^X-Forwarded-Ssl$ "(.+)" HTTP_X_FORWARDED_SSL=$1

RequestHeader set X-Real-IP %{REMOTE_ADDR}s
RequestHeader set X-Forwarded-For %{REMOTE_ADDR}s
RequestHeader set X-Forwarded-Proto "https"

ProxyPass "/" "http://127.0.0.1:45100/"
ProxyPassReverse "/" "http://127.0.0.1:45100/"

ProxyPass "/webhook" "http://127.0.0.1:45100/"
ProxyPassReverse "/webhook" "http://127.0.0.1:45100/"

<Proxy *>
Require all granted

RewriteEngine On

RewriteCond %{HTTP:Upgrade} ^WebSocket$ [NC]
RewriteCond %{HTTP:Connection} ^Upgrade$ [NC]
RewriteRule .* ws://127.0.0.1:45100%{REQUEST_URI} [P]

Header always set Connection "Upgrade"
Header always set Upgrade "websocket"

@zhiru
Copy link
Author

zhiru commented Nov 23, 2024

looking for the erro i saw that .ndv-wrapper css is after .el-dialog

.ndv-wrapper has width: 100% and when is before .el-dialog then works, but i dont why is on diferente positions on file when in https

and the --el-dialog-width is set to auto, not 100% so, gets buggy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in linear Issue or PR has been created in Linear for internal review
Projects
None yet
Development

No branches or pull requests

2 participants