-
Notifications
You must be signed in to change notification settings - Fork 7.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ReAct agent (only?): workflow [null]
that gets passed via "Extra Workflow Inputs" as string, comes out as "null"
#11766
Comments
Hey @Morriz, We have created an internal ticket to look into this which we will be tracking as "GHC-454" |
[null]
that is passed in Set
gets passed as null
to tool, breaking is not empty
[null]
that is passed in Set
gets passed as "null" (str) to tool, breaking is not empty
Hi @Morriz Can you provide more information here as well? It's unclear what you mean by "test output workflow". A workflow JSON with minimal working example would be appreciated. Also, we recommend users to move away from ReAct agents, and use Tools agents as much as possible; ReAct agents are not as reliable. |
@jeanpaul ?? I find react agents to be MORE reliable and I have switched to that from tools agents. I will provide my workflow here in a bit |
[null]
that is passed in Set
gets passed as "null" (str) to tool, breaking is not empty
[null]
that is passed in Set
gets passed as null
to tool, breaking is not empty
@jeanpaul I never saw I did not correctly add the test workflow files in my OP, but have added it now. |
Hi @Morriz, I've looked at your workflows, and I'm not exactly sure what I should observe. When running this, I see that the variable I've used the following workflow to make it a bit easier, and to keep everything in one workflow (be advised, you need to save it before you can actually call the self-contained sub-workflow): |
I would assume that n8n deals with passing on keys that are given undefined values correctly. (It seems messy in the traces, as I see My point is: how can we detect in such setups that we got an empty value passed in the sub-workflow? Can you help me solve that use case? |
[null]
that is passed in Set
gets passed as null
to tool, breaking is not empty
[null]
that gets passed via "Extra Workflow Inputs" as string, comes out as "null"
@jeanpaul I tested it again and this bug still holds. Your assumption that an Unfortunately "Extra Workflow Inputs" does not offer raw json so we can't work around this issue, and I think this needs work by the team to make sure the props passing paradigm holds. |
Bug Description
What the title says.
To Reproduce
null_passing_to_sub_workflows.json
$json.test
is[null]
, but in the receiving workflow it is now "null".Expected behavior
The ReAct agent to not mess with values. I hope the recent refactoring of this agent has fixed this, but maybe my bug report is just in time to get a fix shipped ;)
Operating System
docker
n8n Version
1.68.0
Node.js Version
docker
Database
SQLite (default)
Execution mode
main (default)
The text was updated successfully, but these errors were encountered: