Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signInWithPopup should return an UserCredential ? #241

Open
leonardolessa opened this issue Jun 19, 2019 · 2 comments
Open

signInWithPopup should return an UserCredential ? #241

leonardolessa opened this issue Jun 19, 2019 · 2 comments

Comments

@leonardolessa
Copy link

I'm very unexperienced with Firebase so i'm not sure if its a legit issue.
I'm trying to grab user information from the info returned from signInWithPopup and according to the firebase docs the method should return UserCredential (https://firebase.google.com/docs/reference/js/firebase.auth.Auth.html#signinwithpopup) that would solve my problem.
But according to redux-saga-firebase the object returned is AuthCredential, which is true based on my implementation.
Is this intended? The difference from the firebase docs and the lib implementation or am I missing something?

Btw thanks for sharing the project.

@ctq3103
Copy link

ctq3103 commented May 4, 2020

I got the same problem. I have to use firebase.auth() instead. Are there any other differences between these two that you know, from your experience?

@im-thom
Copy link

im-thom commented May 15, 2020

Yeah I feel like this should definitely be returning a UserCredential.

@ctq3103 Another difference; and the problem I am having is that you cannot get access to things like "IsNewUser" during authentication flow. Gonna have to use the regular firebase auth flow.

If I'm misinterpreting, anyone feel free to let me know 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants