Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make search handle multiple area types #504

Closed
zarino opened this issue Mar 11, 2024 · 0 comments · Fixed by #506
Closed

Make search handle multiple area types #504

zarino opened this issue Mar 11, 2024 · 0 comments · Fixed by #506
Assignees
@zarino
Labels
design This is a front-end thing that doesn’t need a developer

Comments

@zarino
Copy link
Member

zarino commented Mar 11, 2024

Design task, broken out of #487.

  • When searching by postcode, show current constituency, future constituency, and any local authorities (for most postcodes just one, but for some, two) covering that postcode. With an explanation of what the difference is between the area types. This might end up looking a bit like the page you see after entering your postcode on WriteToThem.
  • When searching by place name, show current constituencies, future constituencies, and local authorites which partially match that name. Again, we’ll want to make sure we explain the difference between the area types.
    • Nice to have: the same when searching by person name. (But this might require @struan does a bit more work, making search match against PPCs and Councillors, assuming we even have Councillor persondata in the Hub in the first place.)
@zarino zarino added the design This is a front-end thing that doesn’t need a developer label Mar 11, 2024
@zarino zarino assigned zarino and unassigned lucascumsille Mar 30, 2024
zarino added a commit that referenced this issue Apr 1, 2024
@zarino
Location search now handles all area types
ba6b4b3 
Fixes #504.

AreaSearchView no longer artificially limits results to WMC area_types,
and area_search.html presents matching areas grouped by area_type.

I’ve gone with a custom `grid` layout on the area_search.html (rather
than Bootstrap columns) to more gracefully handle a variable number of
columns – there might be 1, 2, or 3, depending on the search input.

I also fixed a bug in the `highlight` filter, which raised a TypeError
when passed a None `search` parameter. `search` is None when the user
has used geolocation rather than submitting a search term.
struan pushed a commit that referenced this issue Apr 1, 2024
@zarino @struan
Location search now handles all area types
11b4931 
Fixes #504.

AreaSearchView no longer artificially limits results to WMC area_types,
and area_search.html presents matching areas grouped by area_type.

I’ve gone with a custom `grid` layout on the area_search.html (rather
than Bootstrap columns) to more gracefully handle a variable number of
columns – there might be 1, 2, or 3, depending on the search input.

I also fixed a bug in the `highlight` filter, which raised a TypeError
when passed a None `search` parameter. `search` is None when the user
has used geolocation rather than submitting a search term.
struan pushed a commit that referenced this issue Apr 1, 2024
@zarino @struan
Location search now handles all area types
165bd4d 
Fixes #504.

AreaSearchView no longer artificially limits results to WMC area_types,
and area_search.html presents matching areas grouped by area_type.

I’ve gone with a custom `grid` layout on the area_search.html (rather
than Bootstrap columns) to more gracefully handle a variable number of
columns – there might be 1, 2, or 3, depending on the search input.

I also fixed a bug in the `highlight` filter, which raised a TypeError
when passed a None `search` parameter. `search` is None when the user
has used geolocation rather than submitting a search term.
struan pushed a commit that referenced this issue Apr 22, 2024
@zarino @struan
Location search now handles all area types
080c23c 
Fixes #504.

AreaSearchView no longer artificially limits results to WMC area_types,
and area_search.html presents matching areas grouped by area_type.

I’ve gone with a custom `grid` layout on the area_search.html (rather
than Bootstrap columns) to more gracefully handle a variable number of
columns – there might be 1, 2, or 3, depending on the search input.

I also fixed a bug in the `highlight` filter, which raised a TypeError
when passed a None `search` parameter. `search` is None when the user
has used geolocation rather than submitting a search term.
@zarino zarino linked a pull request Apr 23, 2024 that will close this issue
Display local council boundaries and add some basic council data #506
Merged
struan pushed a commit that referenced this issue Apr 24, 2024
@zarino @struan
Location search now handles all area types
a7f5254 
Fixes #504.

AreaSearchView no longer artificially limits results to WMC area_types,
and area_search.html presents matching areas grouped by area_type.

I’ve gone with a custom `grid` layout on the area_search.html (rather
than Bootstrap columns) to more gracefully handle a variable number of
columns – there might be 1, 2, or 3, depending on the search input.

I also fixed a bug in the `highlight` filter, which raised a TypeError
when passed a None `search` parameter. `search` is None when the user
has used geolocation rather than submitting a search term.
@struan struan closed this as completed in 7358922 Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zarino zarino

Labels
design This is a front-end thing that doesn’t need a developer
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Display local council boundaries and add some basic council data mysociety/local-intelligence-hub
2 participants
@zarino @lucascumsille