Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible discrepancy in REWOBetaScheduler Formula (Lines 139-142) #1

Open
porink0424 opened this issue Aug 23, 2024 · 0 comments
Open

Comments

@porink0424
Copy link
Member

I noticed that the formula updating self.communication_loss_ema in REWOBetaScheduler (emecom_gen/model/game/beta_scheduler.py, lines 139-142) appears to differ from the REWO algorithm described in the original paper (https://arxiv.org/abs/1905.04982).
It seems that the coefficients might be applied in different terms.
If you have time, it might be worth checking. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant