Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dropdown for closed captioning options #82

Open
FoxbitDreamtail opened this issue Aug 11, 2024 · 6 comments
Open

Use dropdown for closed captioning options #82

FoxbitDreamtail opened this issue Aug 11, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@FoxbitDreamtail
Copy link

FoxbitDreamtail commented Aug 11, 2024

Version of the game

  • Source Build: Aug.10.2024

What is the enhancement?

change the subtitles tick boxes to a drop-down menu (Additional statement redacted)

Screenshots

image

Additional context

as-is it takes up a lot of unnecessary space in the menu and(Potentially) 2 menu options for subtitles could be confusing as to their meaning and use.

@hackgrid
Copy link
Contributor

hackgrid commented Aug 11, 2024 via email

@FoxbitDreamtail
Copy link
Author

FoxbitDreamtail commented Aug 11, 2024

I redacted the language thing for a reason. I don't see a problem with the drop-down menu with 3 options, Disabled, Subtitles(Dialog Only), and Closed Captions. also, isn't this setting normally in 'Audio' in the original game?

@mwpenny
Copy link
Owner

mwpenny commented Aug 13, 2024

A drop-down is possible and I think it could potentially look okay (use same font as the menu itself), but it's non-negligible work for a pretty small benefit. And selecting the dropdown would result in effectively the same menu being displayed that we have today, but hidden behind one extra button press (inconvenient).

I don't mind keeping this open in case a dropdown is needed for some other menu element, or if someone wants to prototype it, but it will be quite low on the list and maybe not done at all.

You're right that it's normally in "audio". We have less space for menus at this low resolution, and it doesn't fit there. It's really a matter of perspective. After all, captions appear visually :)

@mwpenny mwpenny added the enhancement New feature or request label Aug 13, 2024
@FoxbitDreamtail
Copy link
Author

FoxbitDreamtail commented Aug 15, 2024

You're right that it's normally in "audio". We have less space for menus at this low resolution, and it doesn't fit there. It's really a matter of perspective. After all, captions appear visually :)

What about adding scrolling in the menus? it would make chapter select a little more pleasant and closer to the Console versions, and the cramped nature of the screen would be less of an issue!

@mwpenny
Copy link
Owner

mwpenny commented Aug 16, 2024

Scrolling already exists for the control bindings menu, but that one's a bit different (just a list of selectable rows). The other menus don't really lend themselves well to it, particularly with the sliders. It's also easier for players if they can see everything at once where possible.

If more menu entries get added to the point of requiring scrolling outside of the controls menu, it can be tackled at that time. The menus would essentially need to be redone.

For the new game menu, console versions use a similar UI but also include arrows to indicate that scrolling is possible. Here is the Switch version:
image.
If this is what you mean, I agree it would be an improvement (and could also apply to the save/load menu). It isn't hard to add but is a low priority right now (PRs welcome).

@mwpenny mwpenny changed the title Closed Captioning Request Use dropdown for closed captioning options Aug 16, 2024
@FoxbitDreamtail
Copy link
Author

For the new game menu, console versions use a similar UI but also include arrows to indicate that scrolling is possible. Here is the Switch version: image. If this is what you mean, I agree it would be an improvement (and could also apply to the save/load menu). It isn't hard to add but is a low priority right now (PRs welcome).

Yeah, that's what I meant, all the console versions look the same, the XB360 version of Portal has an identical menu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants