Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create helper types for enums, and expose expected response attributes #67

Open
mwpenny opened this issue Feb 12, 2023 · 0 comments
Open

Comments

@mwpenny
Copy link
Owner

mwpenny commented Feb 12, 2023

Better attribute handling would make this library easier to use and avoid the need to guess/experiment as much when using it. Additionally, the meaning of some attribute values is not obvious (see #65).

This issue tracks two related enhancements:

  1. Some ad attributes are enums. Currently, kijiji-scraper exposes the internal value. Create helper types (similar to those that exist for location and category IDs) for exposing all possible enums, their entries, and the corresponding internal values.
  2. The possible attributes an ad can have depend on its category. Provide a way to determine all possible attributes that may be returned when scraping/searching (ideally at compile time via TypeScript, with a run-time API for JavaScript users).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant