Clean up the voting system and uncouple the classification. #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The purpose here is to uncouple the flask app from all the classification. And the voting system has been completely reworked to make it more readable and prepare for the ordering of answers.
|
Strongly support the pull |
|
I also forgot to say, it adds the ids to the output of the classifier! |
|
Thank you for your efforts! |
|
You can just make a branch with the "manuscript-version" and keep updating main. That way the manuscript-version will never change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose here is to uncouple the flask app from all the classification. And the voting system has been completely reworked to make it more readable, remove duplicate code and prepare for the ordering of answers.
All the entries in test.csv give the same answers as the current NP-Classifier instance on the ucsd servers (the entry 2 is different from what is expected in that file in both this version and the UCSD version so it was probably not updated with the new model.
I can work on the ordering of ids and all of that, but first it would be more practical if the last pull requests were accepted (and we can discuss what I did and why I did it that way if you have questions of course).