Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Praxis code review comments #1

Open
souravpujara27 opened this issue Jan 10, 2022 · 1 comment
Open

Praxis code review comments #1

souravpujara27 opened this issue Jan 10, 2022 · 1 comment
Assignees
@souravpujara27
Labels
enhancement New feature or request

Comments

@souravpujara27
Copy link

souravpujara27 commented Jan 10, 2022 •
edited
Loading

1.Keep the cron part of TokenPurgeScheduler in app.properties so that these can be modified easily
2.GlobalConfig either keep in db or in app.properties
3. Remove spring.email.password from properties and should be added in the server or aws env.properties
@anmolvermamm
Copy link

@souravpujara27 Thanks for the review!
Can we by any chance breakdown these into different issue and add tags to each. We can probably take these up as we get bandwidth ?

@anmolvermamm anmolvermamm added the enhancement New feature or request label Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@souravpujara27 souravpujara27

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anmolvermamm @souravpujara27